Skip to content

DM-7630: Display null_string when value is null #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2016
Merged

DM-7630: Display null_string when value is null #185

merged 1 commit into from
Sep 19, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Sep 16, 2016

  • delegate IpacTableReader to use DataGroupReader instead.
  • fix selectInfo not updating totalRows

Make sure that table with Null Values defined are printed and shown as defined. ie. 'null' -> 'null'.
If one is not given, empty string is used by default.

@loitly
DM-7630: Display null_string when value is null
24e6442 
- delegate IpacTableReader to use DataGroupReader instead.
- fix selectInfo not updating totalRows
@ejoliet
Copy link
Contributor

ejoliet commented Sep 19, 2016

Looks great to me. I'm not sure about 'null' values should be plotted as '0' though. But that is different discussion maybe @tgoldina and @xiuqin can comment on that. For now i would merge it and discuss later.Thanks!
Reviewed.

@loitly loitly merged commit 59833e0 into dev Sep 19, 2016
@loitly loitly deleted the DM-7630_ipac_tbl_nullstr branch September 19, 2016 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loitly @ejoliet